Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate image loading from Picasso to Coil #11201

Open
wants to merge 9 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jun 22, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Migrate the image loading functionality from Picasso to Coil. Picasso has not had a new release for some time, and it has been recommended to move to other libraries. Coil also allows the notification icon loading to be greatly simplified, and it provides default configurations for its memory and disk caches.
  • Remove the image indicator toggle from the settings as Coil does not have that functionality. Logging has been enabled instead for debug builds.
  • Enable RGB-565 support for low-RAM devices only.
  • This change is needed for PR Migrate comment fragments to Jetpack Compose #11060 as it makes use of Coil's Compose functionality.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jun 22, 2024
@TobiGr TobiGr added the dependency Issues and PRs related to dependencies label Jun 22, 2024
@Isira-Seneviratne Isira-Seneviratne marked this pull request as draft June 22, 2024 09:35
@Isira-Seneviratne Isira-Seneviratne marked this pull request as ready for review June 22, 2024 11:35
Copy link

sonarcloud bot commented Jun 22, 2024

@opusforlife2
Copy link
Collaborator

Enable RGB-565 support for low-RAM devices only.

Thank you for thinking of low-RAM devices. ❤️

@Isira-Seneviratne
Copy link
Member Author

Enable RGB-565 support for low-RAM devices only.

Thank you for thinking of low-RAM devices. ❤️

I initially enabled it for all devices, but changed that as the documentation recommends it for low-RAM devices only.

@opusforlife2
Copy link
Collaborator

What's the threshold, BTW? 3GB?

@Isira-Seneviratne
Copy link
Member Author

What's the threshold, BTW? 3GB?

It depends on the device configuration, according to the documentation, but it's generally 1 GB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies size/giant PRs with more than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants