Convert @IntDefenums to normal enums where rational
#13021
+27
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
@IntDefenums to normal enums where rationalReasons to not convert other
@IntDefto enums:...NotificationConstants.java- heavily relies on int semantics, uses int semantics for storing data, very messy, part of the player... (Just formally could be converted but it is really a mess)...CollapsibleView.java- probably will be deleted in Remove file orphaned for long time #13019...NotificationMode.kt- should be int to store in db. Used inside other structs so adding@TypeConverteris not applicable (?)...FragmentStatePagerAdapterMenuWorkaround- external and deprecated code copied from library and edited for adding some workaround. No need to "fix"APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence