Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for advanced content and sort filters in searches #8837

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Commits on Dec 31, 2023

  1. searchfilters: dynamically generate UIs and evaluate selected sort an…

    …d content filters
    
    SearchFilterLogic.java:
    =======================
    This class handles all the user interaction with the content and sort filters
    of NewPipeExtractor.
    
    The class works standalone to just get the default selected filters eg.
    during init phase. See in SearchFragment#initializeFilterData()
    
    BaseSearchFilterUiGenerator.java:
    =================================
    It extends SearchFilterLogic and is used as a base class to implement the UI interface
    for content and sort filter dialogs eg. SearchFilterDialogGenerator or
    SearchFilterOptionMenuAlikeDialogGenerator.
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    e2bce99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    651a333 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c038aa View commit details
    Browse the repository at this point in the history
  4. searchfilters: Moving DividerItem from NewPipeExtractor into NewPipe

    DividerItem was inserted in the content filter framework in the
    NewPipeExtractor to have a section title for YoutubeMusic. But as
    UI releated stuff seems a bit out of place in the Extractor I came
    up with injecting the DividerItem aka section title in the frontend
    without having to change too much in the frontend.
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    7c650f6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    05ffe27 View commit details
    Browse the repository at this point in the history
  6. searchfilters: 2nd Ui: Action menu feel alike dialog

    Dialog looks similar to a action menu based approach but is faster.
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    466ddb6 View commit details
    Browse the repository at this point in the history
  7. searchfilters: 3rd Ui: action based UI (enhanched legacy menu)

    This approach is more or less a hack but if all else fails. Could later
    be dropped or right away.
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    a0d576f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a434af6 View commit details
    Browse the repository at this point in the history
  9. searchfilters: ViewModel for SearchFragment* and SearchFilter*DialogF…

    …ragment
    
    The ViewModel that hosts the search filters logic. It facilitates
    the communication with the SearchFragment* and the
    SearchFilter*DialogFragment based search filter UI's
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    8858e7e View commit details
    Browse the repository at this point in the history
  10. searchfilters: rework getTranslatedFilterString() method to use NewPi…

    …peExtractor's LibraryStringIds class
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    9451167 View commit details
    Browse the repository at this point in the history
  11. searchfilters: replace old filter interaction and integrate new dialo…

    …g into SearchFragment
    
    There is also a configuration option to choose between different search
    UI's
    evermind-zz committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    6bcca69 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2024

  1. use FilterItem for tabs

    evermind-zz committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    7b300ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4eb71a8 View commit details
    Browse the repository at this point in the history