Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BufferedReader#lines() #1246

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Use BufferedReader#lines() #1246

merged 4 commits into from
Jan 27, 2025

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Dec 7, 2024 •
edited
Loading

Use the lines() method in BufferedReader, which is desugared for Android versions below 7.0 (when it was first introduced in Android).

@ShareASmile ShareASmile added codequality Improvements to the codebase to improve the code quality waiting for review Most of the work is done, PR is now ready for a review labels Dec 10, 2024
@litetex litetex self-requested a review January 27, 2025 21:21
@litetex litetex force-pushed the BufferedReader-lines branch from 4869ab1 to e475b29 Compare January 27, 2025 21:21
litetex
litetex approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM
Did some rebasing and polishing. Test are working and import also works with NewPipe itself.

Let's get this merged

@litetex litetex merged commit 3a33cef into TeamNewPipe:dev Jan 27, 2025
3 of 4 checks passed
@ShareASmile ShareASmile added enhancement New feature or request and removed waiting for review Most of the work is done, PR is now ready for a review labels Jan 28, 2025
@Isira-Seneviratne Isira-Seneviratne deleted the BufferedReader-lines branch January 28, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isira-Seneviratne @litetex @ShareASmile