Add search link type in the extractor #950
Conversation
Sola0404
commented
Oct 23, 2022
•
Sola0404
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
There was a problem hiding this comment.
Looks almost good to me. @FireMasterK could you take a look, too? Also, do we need tests for the link handler?
| @@ -282,6 +290,27 @@ public CommentsExtractor getCommentsExtractor(final String url) throws Extractio | |||
| // Utils | |||
| //////////////////////////////////////////////////////////////////////////*/ | |||
|
|
|||
| public final String getIdByUrl(final String url) throws ParsingException{ | |||
There was a problem hiding this comment.
Instead of adding this function just to use it for search URLs in the client, I think a better option is what I suggested in the client review
| throw new ParsingException("the url given is not a YouTube-URL"); | ||
| } | ||
|
|
||
| final String listID = Utils.getQueryValue(urlObj, "search_query"); |
There was a problem hiding this comment.
Change listId to searchQuery and update the exception message accordingly
Honestly, I don't know how this part of the extractor works at all, so I would be the wrong candidate. We likely do need tests, since I did check the Channel link handler, which has tests. |
|
@Sola0404 do you plan to keep working on this? Also, you should also implement this for all other services, and not just for youtube, if possible (shouldn't be too difficult though). |
