Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to github actions from travis CI #32

Merged
merged 6 commits into from
Nov 28, 2021

Conversation

XiangRongLin
Copy link
Contributor

@XiangRongLin XiangRongLin commented Nov 27, 2021

@XiangRongLin
Copy link
Contributor Author

This can only be done after #33

@TheAssassin
Copy link
Member

I could imagine it's much easier to just run your commands in a python:3 Docker image. Mind if I try that out?

@XiangRongLin
Copy link
Contributor Author

Feel free to take over. I added some stuff that o could fix quickly (and dirty).


I managed to run it locally after i figured out to install the dependencies in user mode, meaning using pip install --user.

Before that i was using nectos/act but that took way to long

@TheAssassin
Copy link
Member

I'll add a shell script that is going to allow you to run it locally as the CI would. This is a pattern I use in most repositories. Being able to reproduce results locally is important.

@XiangRongLin
Copy link
Contributor Author

XiangRongLin commented Nov 28, 2021

That what i use https://github.com/nektos/act for. But it's big and compativly slow and with many caveats

@TheAssassin TheAssassin marked this pull request as ready for review November 28, 2021 20:59
@TheAssassin
Copy link
Member

I guess we have to merge this initially in order to see if it works. In my temporary fork, it looks good, though.

For the record: this is one of the reasons I love sphinx-doc. It provides this feature out of the box.

@TheAssassin TheAssassin merged commit d37689a into TeamNewPipe:master Nov 28, 2021
@XiangRongLin
Copy link
Contributor Author

@TheAssassin I collected the problems i have found in #33. Of the 2 remaining problems, only 4 is critical in order to have the CI pipeline run successfully.
The script probably needs to adjusted so that it either

  1. reads in all files at the start (con: growing memory load, should be ok with the current 64kB)
  2. or load the referenced file when needed (con: same file gets loaded multiple times)
    so one can check references to other files.

I would be in favor of 1

@XiangRongLin XiangRongLin deleted the github_actions branch November 29, 2021 07:14
@TheAssassin
Copy link
Member

Either will work. There is really no performance optimization required. I mean, if you really wanted, you could implement a lazy loader that caches the contents...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants