-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website language reworked #178
base: master
Are you sure you want to change the base?
Conversation
index.html
Outdated
@@ -235,9 +235,9 @@ <h3>Background Player</h3> | |||
<p><strong>Listen to your favourite music while using other apps:</strong></p> | |||
<ul> | |||
<li>Play in background</li> | |||
<li class="text-success">Pro tip: close NewPipe to save RAM and battery</li> | |||
<li class="text-success">Pro tip: Close NewPipe to save RAM and battery</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was correct as is.
index.html
Outdated
<li>Create playlists for an endless music experience</li> | ||
<li>Save mobile data volume (we only download the audio)</li> | ||
<li>Saves even more mobile data with auto only</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "audio only".
<li class="text-success">Pro tip: switch between all players with one click</li> | ||
<li>Available for all Android versions</li> | ||
<li>In full comfort of our normal video player</li> | ||
<li class="text-success">Pro tip: Switch between all players with one click</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also should be small letter after colon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a full sentence, so can use big versal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually fine in American English, but not in British English. Interesting.
<li>Easily open what you watch most</li> | ||
<li class="text-success">Control what we keep for you</li> | ||
<li>Watch favourites again</li> | ||
<li>Search-suggestions based on your last searches</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was correct as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but I added it to avoid ~ Search for/in suggestions based on your last searches"
@@ -399,7 +399,7 @@ <h3>What other people think</h3> | |||
Marcus Hoffmann | |||
</a> | |||
</p> | |||
<p class="user-statement">one of the most used apps on my Phone</p> | |||
<p class="user-statement">one of the most used apps on my phone</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't user statements be kept as is as they are quoted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but there should also be the correct quote signs, and they shouldn't be red. Leaving for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could write a /sic
if you want to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wans't in the original quote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sic
is used when you're quoting someone but you want to indicate that whatever error the reader sees is part of the quote and not a typo caused by you.
index.html
Outdated
@@ -679,19 +678,19 @@ <h4>NewPipe is free and open source</h4> | |||
<h3 class="title">Support NewPipe</h3> | |||
</div> | |||
<div class="col-md-6 tile tile-left" id="tile-free"> | |||
<h4>Why NewPipe is free</h4> | |||
<h4>Why NewPipe is libre and gratis</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't they opposites? https://en.wikipedia.org/wiki/Gratis_versus_libre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hence the and. Adding Oxford comma to drive the point home.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is needed.
@@ -99,7 +99,7 @@ <h3 id="features-title">Main Features</h3> | |||
<div class="container container-double"> | |||
<div class="row is-flex"> | |||
<div class="col-md-9 feature-detail" id="lightweight"> | |||
<h3 style="font-weight: bold">NewPipe - the smart streaming solution</h3> | |||
<h3 style="font-weight: bold">NewPipe—against the stream of the current</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h3 style="font-weight: bold">NewPipe—against the stream of the current</h3> | |
<h3 style="font-weight: bold">NewPipe — against the current of the stream</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No spacing is how it is used in https://hosted.weblate.org/translate/newpipe/strings/de/?checksum=f34666a9044eb73d
Amounts to choice of style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only seen the space being absent when you want to show interruption.
"Hey! How are you doin-- whoa!"
(pretend that's an em dash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is either side or nothing. https://www.thepunctuationguide.com/em-dash.html is the one I use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to that website, the em dash shouldn't even be used here. I think it should be a colon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean kinda unrelated but maybe against streams?
Also, I like Opuses dash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opusforlife2 The change doesn't carry over the duality. current works with stream, and can either be in a stream as a resistance, or a virtual one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using this metaphorically, then I would need some more clarification.
In conventional usage, however, we use it this way. 'Current' is the direction the stream flows in. You go against the current, not the stream itself.
index.html
Outdated
<li>Create playlists for an endless music experience</li> | ||
<li>Save mobile data volume (we only download the audio)</li> | ||
<li>Saves even more mobile data with auto only</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Saves even more mobile data with auto only</li> | |
<li>Saves even more mobile data with audio only</li> |
<li>Easily open what you watch most</li> | ||
<li class="text-success">Control what we keep for you</li> | ||
<li>Watch favourites again</li> | ||
<li>Search-suggestions based on your last searches</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Search-suggestions based on your last searches</li> | |
<li>Search suggestions based on your last searches</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -410,7 +410,7 @@ <h3>What other people think</h3> | |||
Neil Simpson | |||
</a> | |||
</p> | |||
<p class="user-statement">Such a great app - it is probably the app I use most on my phone!</p> | |||
<p class="user-statement">Such a great app—it is probably the app I use most on my phone!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p class="user-statement">Such a great app—it is probably the app I use most on my phone!</p> | |
<p class="user-statement">Such a great app — it is probably the app I use most on my phone!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
<li>Your donations cover a majority of our costs</li> | ||
<li class="text-success">F-Droid, Weblate, Sentry and other companies offer their services to open source projects for free</li> | ||
<li>Powered by a growing and generous community</li> | ||
<li>To make the Internet for everyone</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>To make the Internet for everyone</li> | |
<li>To make the Internet more accessible for everyone</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought "to make the Internet for everyone" is an OK slogan/saying. NewPipe should be better for blind users before the accessible for everyone holds true. I think the brevity encompasses everyone nicely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the internet _____ for everyone. It's missing an adjective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going for "To make the Internet for everyone"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. To me it reads like Newpipe is creating this thing called the Internet for everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe focus on the media part, what NewPipe is about?
To make media streaming for everyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already know what it is about from earlier, this is a greater goal. To its greatest extent, it is summarized in those 8 words. Improvements would be, fewer words, better sounding sentence, or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the Internet a better place for everyone?
Co-authored-by: Mohammed Anas <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
Co-authored-by: opusforlife2 <[email protected]>
index.html
Outdated
<p class="text-justify-md"><span class="red">NewPipe</span> has been created with the purpose of getting the original YouTube experience on your smartphone without annoying ads and questionable permissions.</p> | ||
<p>The application is open source and you can check on it at <a href="https://github.com/TeamNewPipe/NewPipe/">GitHub</a>.</p> | ||
<p><strong>Internet video content in an intuitive, feature-rich and privacy friendly app.</strong></p> | ||
<p class="text-justify-md"><span class="red">NewPipe</span> was created to get the original YouTube experience on your smartphone without annoying ads or questionable permissions.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p class="text-justify-md"><span class="red">NewPipe</span> was created to get the original YouTube experience on your smartphone without annoying ads or questionable permissions.</p> | |
<p class="text-justify-md"><span class="red">NewPipe</span> was created to get the original YouTube experience on your smartphone without annoying ads or questionable permissions, but has grown into so much more over time.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, I guess it could need a complete overhaul, but this gives a better base!
<li>Download the resolution you need</li> | ||
<li>Video or audio only, with or without captions</li> | ||
<li>Many file formats</li> | ||
<li>In any resolution</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>In any resolution</li> | |
<li>In any available resolution</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't mean anything now. Not that it was great before. Can you get a list of all available resolutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken from here: https://support.google.com/youtube/answer/6375112
2160p: 3840x2160
1440p: 2560x1440
1080p: 1920x1080
720p: 1280x720
480p: 854x480
360p: 640x360
240p: 426x240
index.html
Outdated
<li>Only send info required to get video and channel details</li> | ||
<li>Decide what info is kept</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike using info here, it sounds so informal imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call
<li>Create playlists for an endless music experience</li> | ||
<li>Save mobile data volume (we only download the audio)</li> | ||
<li>Saves even more mobile data with audio only</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Saves even more mobile data with audio only</li> | |
<li>Saves even more mobile data with audio only stream</li> |
index.html
Outdated
@@ -247,16 +247,16 @@ <h3>Background Player</h3> | |||
<div class="col-md-9 feature-detail" id="popup" > | |||
<h3>Popup Player</h3> | |||
<div class="feature-media"> | |||
<img src="/img/screenshots/shot_05.png" class="img-responsive" alt="popup player in browser app" /> | |||
<img src="/img/screenshots/shot_05.png" class="img-responsive" alt="popup player in web-browser app" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src="/img/screenshots/shot_05.png" class="img-responsive" alt="popup player in web-browser app" /> | |
<img src="/img/screenshots/shot_05.png" class="img-responsive" alt="popup player inside a web-browser app" /> |
<li>Easily open what you watch most</li> | ||
<li class="text-success">Control what we keep for you</li> | ||
<li>Watch favourites again</li> | ||
<li>Search-suggestions based on your last searches</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -399,7 +399,7 @@ <h3>What other people think</h3> | |||
Marcus Hoffmann | |||
</a> | |||
</p> | |||
<p class="user-statement">one of the most used apps on my Phone</p> | |||
<p class="user-statement">one of the most used apps on my phone</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could write a /sic
if you want to
@@ -410,7 +410,7 @@ <h3>What other people think</h3> | |||
Neil Simpson | |||
</a> | |||
</p> | |||
<p class="user-statement">Such a great app - it is probably the app I use most on my phone!</p> | |||
<p class="user-statement">Such a great app—it is probably the app I use most on my phone!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
<li class="text-success">NewPipe is available for free</li> | ||
<li>Licensed <a href="https://github.com/TeamNewPipe/NewPipe/blob/master/LICENSE">GPLv3+</a>.</li> | ||
<li>Get NewPipe from <a href="https://f-droid.org/packages/org.schabi.newpipe/">F-Droid</a> and discover more libre apps.</li> | ||
<li class="text-success">NewPipe is gratis, and welcomes donations by improving</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
donations in form of an improvement/PR, or donations in order to be able to improve it, which would be kinda wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be a transitive verb. Meaning of "improving itself"
<li>Your donations cover a majority of our costs</li> | ||
<li class="text-success">F-Droid, Weblate, Sentry and other companies offer their services to open source projects for free</li> | ||
<li>Powered by a growing and generous community</li> | ||
<li>To make the Internet for everyone</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe focus on the media part, what NewPipe is about?
To make media streaming for everyone?
<p>The application is open source and you can check on it at <a href="https://github.com/TeamNewPipe/NewPipe/">GitHub</a>.</p> | ||
<p><strong>Internet video content in an intuitive, feature-rich and privacy friendly app.</strong></p> | ||
<p class="text-justify-md"><span class="red">NewPipe</span> was created to get the original YouTube experience on your smartphone without annoying ads or questionable permissions, and is now the future.</p> | ||
<p>Copylefted libre software available on <a href="https://github.com/TeamNewPipe/NewPipe/">GitHub</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Copylefted libre software available on <a href="https://github.com/TeamNewPipe/NewPipe/">GitHub</a>.</p> | |
<p>This is copylefted libre software, available on <a href="https://github.com/TeamNewPipe/NewPipe/">GitHub</a>.</p> |
<li>Choose between video, audio or captions download</li> | ||
<li>Select the most suitable file format</li> | ||
<li>Download the resolution you need</li> | ||
<li>Video or audio only, with or without captions</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Captions are a separate download option. Your phrasing makes it sound like they get downloaded alongside.
<li>Video or audio only, with or without captions</li> | |
<li>Video, audio, or just the captions</li> |
@@ -432,7 +432,7 @@ <h3>What other people think</h3> | |||
Arthur Reeder | |||
</a> | |||
</p> | |||
<p class="user-statement">NewPipe is one of the best applications on mobile today.</p> | |||
<p class="user-statement">NewPipe is one of the best apps on mobile today.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mobile Android?
No description provided.