Add playsinline attribute to video tag #3938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #3734 by adding the playsinline attribute to the video tag in VideoPlayer.vue. This attribute is required for iOS devices to play videos inline instead of going into fullscreen mode by default.
Deploying piped with
|
| Latest commit: |
4e8b0ed
|
| Status: | 🚫 Build failed. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -5,7 +5,7 @@ | |||
| class="relative max-h-screen w-full flex justify-center" | |||
| :class="{ 'player-container': !isEmbed }" | |||
| > | |||
| <video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" /> | |||
| <video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" playsinline /> | |||
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline with ⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······
Suggested change
| <video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" playsinline /> | |
| <video | |
| ref="videoEl" | |
| class="w-full" | |
| data-shaka-player | |
| :autoplay="shouldAutoPlay" | |
| :loop="selectedAutoLoop" | |
| playsinline | |
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3734 by adding the playsinline attribute to the video tag in VideoPlayer.vue.
This attribute is required for iOS devices to play videos inline instead of going into fullscreen mode by default.