.cs files #42
.cs files #42
Conversation
|
|
||
| public static class TemporalClientExtensions | ||
| { | ||
| public static async Task<bool> IsWorkflowRunning<T>(this ITemporalClient client, string workflowId) |
There was a problem hiding this comment.
No value in the type parameter here or in the handle extensions
There was a problem hiding this comment.
Added for ease of use and to reduce duplication. It calls another extension with a handle statuses check
There was a problem hiding this comment.
| public static async Task<bool> IsWorkflowRunning<T>(this ITemporalClient client, string workflowId) | |
| public static async Task<bool> IsWorkflowRunning(this ITemporalClient client, string workflowId) |
I am saying everywhere in these extensions you are accepting a WorkflowHandle with a type parameter unnecessarily, you can just accept WorkflowHandle.
| catch (RpcException ex) | ||
| { | ||
| if (ex.Code is RpcException.StatusCode.NotFound) | ||
| return false; | ||
|
|
||
| throw; | ||
| } |
There was a problem hiding this comment.
| catch (RpcException ex) | |
| { | |
| if (ex.Code is RpcException.StatusCode.NotFound) | |
| return false; | |
| throw; | |
| } | |
| catch (RpcException ex) when (ex.Code == RpcException.StatusCode.NotFound) | |
| { | |
| return false; | |
| } |
Easier to read
|
|
||
| _unitOfWork.Repository<DAL.Entities.Flight>().Update(flight); | ||
|
|
||
| await _unitOfWork.SaveChangesAsync(); |
There was a problem hiding this comment.
Should pass activity execution context's cancellation token to downstream calls
| } | ||
|
|
||
| [Activity] | ||
| public Task<FlightDetailsModel> AssignSeats(FlightDetailsModel flight) |
There was a problem hiding this comment.
You don't have to make these return Task if they don't do anything async
| [Workflow] | ||
| public class FlightWorkflow | ||
| { | ||
| private readonly ActivityOptions _activityOptions = new() |
| _saga.OnCompensationError(log => | ||
| { | ||
| log.Add("Compensation error. Manual intervention required!"); | ||
|
|
||
| return Task.CompletedTask; | ||
| }); | ||
|
|
||
| _saga.OnCompensationComplete(log => | ||
| { | ||
| log.Add("Compensation completed successfully"); | ||
|
|
||
| return Task.CompletedTask; | ||
| }); |
There was a problem hiding this comment.
These seem like things that should be part of the Saga construction, not done in the exception handler
| { | ||
| _saga.OnCompensationError(log => | ||
| { | ||
| log.Add("Compensation error. Manual intervention required!"); |
There was a problem hiding this comment.
Usually if manual intervention is required, the workflow is put in a state where it can be done. If the workflow completes (even a failure), people are not likely to see that they need to do something
| RetryPolicy = new Temporalio.Common.RetryPolicy | ||
| { | ||
| } |
There was a problem hiding this comment.
| RetryPolicy = new Temporalio.Common.RetryPolicy | |
| { | |
| } |
This is the same as leaving it unset from a behavior POV
| StartToCloseTimeout = TimeSpan.FromSeconds(60), | ||
| RetryPolicy = new RetryPolicy | ||
| { | ||
| InitialInterval = TimeSpan.FromSeconds(15), |
There was a problem hiding this comment.
Usually when altering activities to change from the default, it's not a global change but specific to an activity
|
|
||
| try | ||
| { | ||
| _log.Add($"Attempting compensation {i}..."); |
There was a problem hiding this comment.
Might as well use a real logger instead of a string list
No description provided.