This repository has been archived by the owner on May 11, 2021. It is now read-only.
Added Google sign-on option for CAST team #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/zquestz/omniauth-google-oauth2 It was bugging me, so I added it.
suninthesky
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
That's nifty. Perhaps we make it clear in the link that it's for staff to sign in as it could be frustrating/confusing otherwise. Also some visual separation from the forgot password might help.
@trompodrone do you have any thoughts on language/presentation to make it clear the 'Sign in with Google' link is for staff only?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much all boilerplate code from https://github.com/zquestz/omniauth-google-oauth2 with a little tweaking of the Devise login page to make the links behave.
I've added the Google App ID and App Secret variables to Heroku.
Currently it only accepts @wearecast.org.uk emails, and won't create a new user if one doesn't exist.