-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oasis Welness W-12 #52
base: main
Are you sure you want to change the base?
Conversation
created sections and footer
added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Maria-Manuela and Lorenzo, big congrats for completing your design! It looks ✨ awesome ✨ The site looks very close to the design and followed our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result, the button styled component is a great example! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:
- footer: alignment of buttons should be centered (justify-content: space-around)
- on tablet and mobile: card corner doesn’t match the design
A requirement was to make the app responsive on screens starting from 320px:
- on mobile: 95 - Keep an eye on responsiveness on small screen
Fix these little things to pass the assignment, really well done 👏
I really loved to worked with styled components, for someone like me who loose the focus so easily, this gave more control over the styling. It´s a bless! |
Netlify link
https://oasiswelnesscenter.netlify.app/
Collaborators
[Looziolooz]