-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w12-design-handoff #53
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Your landing page looks really nice and the design is really pretty. The page looks good on all sizes and styling wise everything looks consistent. I did not use styled components so it was nice to see that and looks like you really got the hang of it. Your folder structure and code is organized so easy to follow. I also thought it was nice to have the form "work" if its filled in. Would be nice to have seen the design for comparison. Great job!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello ladies 💠 wow! Big congrats for this other achievement! It looks ✨ awesome ✨ The site looks very close to the design and followed our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result! How cool you created your own carousel! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:
- background on input field could be grey too not white
- accessibility: you scored 86 minimum needed is 95
No biggie, you nailed it! Fix accessibility and you're good to go 🚀 ⭐
Netlify link
https://golden-kitsune-efb49e.netlify.app/
Collaborators
[Josephineoderland, johannacatalinismith]