Alex & Axel design-handoff #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fonts and adjusted content to fit mobile media queries
Added a component for carousel and strted to create navbar
Finished navbar layout for mobile
Added testimonial/statement section
Co-authored-by: Alexandra Franzén <[email protected]>
Added dropdown menu and styling
Added component and context for carousel function
added media queries for MakeYourPick.jsx file
* added media queries for two components * fixed responsive app * dropdown media queries
AntonellaMorittu
suggested changes
May 3, 2024
There was a problem hiding this comment.
Hello Axel and Alex, congrats for completing your week 12 assignment! The site looks very close to the design and followed most of our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result! How cool you made a carousel using an external library! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to pass this week's assignment or just to improve it even further:
- “our offerings” section should have horizontal padding of 150px and there should be a gap on 120px in between every section
- in general, check paddings and margins, especially in the footer
- check header and other items alignments (i.e. "explore our camps" button should be left aligned)
- use always format.svg for images when available in the design, this will ensure HQ on any screen size
- accessibility: you scored 74 would be best 95
- remove margin: 8px applied to the body element
- horizontal scrolling to show both items missing on Make Your Pick section
Fix these little things and you're clear! 🌷💪
AntonellaMorittu
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://monumental-banoffee-da2acb.netlify.app/
PS. Don't forget to add it in your readme as well.
Collaborators
Add your collaborators here. Write their GitHub usernames in square brackets. If there's more than one, separate them with a comma, like this:
[Xikitita]