Daily Spells app by Anna and Erika #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded in header and app.jsx
…lls in the jsx-file
…ted them into the header and the personalized spells component
updated h2 heading in personalized spells
JennieDalgren
approved these changes
Nov 14, 2024
Comment on lines
+6
to
+17
| color: #000; | ||
| text-align: center; | ||
| font-family: "Yeseva One"; | ||
| font-size: 3rem; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| margin: 0; | ||
|
|
||
| //Desktop styling | ||
| @media (min-width: 1200px) { | ||
| font-size: 6rem; | ||
|
|
Comment on lines
+22
to
+49
| color: #FFF; | ||
| text-align: center; | ||
| font-family: "Yeseva One"; | ||
| font-size: 1.5rem; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| margin: 0; | ||
|
|
||
| // Tablet styling | ||
| @media (min-width: 768px) { | ||
| font-size: 2.25rem; | ||
| } | ||
|
|
||
| // Desktop styling | ||
| @media (min-width: 1200px) { | ||
| font-size: 4rem; | ||
| text-align: left; | ||
| } | ||
|
|
||
| ` | ||
|
|
||
| const Level3 = styled.h3` //Heading pop-up | ||
| color: #000; | ||
| font-family: "Yeseva One"; | ||
| font-size: 1.25rem; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| line-height: normal; |
Comment on lines
+79
to
+97
| color: #FFF; | ||
| text-align: center; | ||
| font-family: "Josefin Sans"; | ||
| font-size: 1.5rem; | ||
| font-weight: 400; | ||
| line-height: 1.95rem; | ||
| `; | ||
|
|
||
| export const Typography6 = styled.p` //Quotes typography, exported this to be able to use white color | ||
| color: ${(props) => (props.isWhite ? '#fff' : '#000')}; // default black - choise to be white | ||
| text-align: ${(props) => (props.isCentered ? 'left' : 'center')}; | ||
| font-family: "Josefin Sans"; | ||
| font-size: 0.75rem; | ||
| font-style: ${(props) => (props.noItalic ? 'normal' : 'italic')}; | ||
| font-weight: 300; | ||
| line-height: 1.1rem; | ||
|
|
||
| @media (min-width: 768px) { | ||
| font-size: 1rem; |
Comment on lines
+115
to
+122
| const Tag = level === 1 ? Level1 | ||
| : level === 2 ? Level2 | ||
| : level === 3 ? Level3 | ||
| : level === 4 ? Typography4 | ||
| : level === 5 ? Typography5 | ||
| : level === 6 ? Typography6 | ||
| : level === 7 ? Typography7 | ||
| : `h${level}`; // Use `h2`, `h3` directly for levels 2 and 3 |
There was a problem hiding this comment.
this is clever, however it is a bit harder to understand instead of calling the different texts heading1 or paragraph or similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://dailyspells.netlify.app/
Collaborators
Anna Hansen
Erika Olsson
[Anna2024WebDev, erikamolsson]