Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elina Eriksson Hult - Project Pizza #144

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ElinaEH
Copy link

@ElinaEH ElinaEH commented Sep 6, 2024

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on completing this project! 🎉

JavaScript

  • You’re using if-else statements effectively to control the flow based on user input.
  • You're using let to declare variables, which is good. It is appropriate for variables whose values change
  • You're handling invalid choices nicely in some places but could make this more consistent across the entire code.
  • Consider parsing the inputs to be able to determine if the user wrote a number or not. Especially for age where you want the input to be a number to be able to do the checks
  • Consider ending the flow if a user types an invalid input. You can do this with the return keyword

Clean Code

  • The code is overall clean with consistent indentation
  • Be consistent with whether you're using semicolons or not! If you decide to use them, you need to learn where they should go. No mix please!

Keep up the good work Elina, but remember these things going forward ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants