Estefanny's PR pizzabot #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 4, 2024 21:59
…ile loop. Added step 3.
HIPPIEKICK
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Great work on tackling this project! 🎉
JavaScript
- Nice usage of the while loop and good control flow 👍
- You defined a helpful error message errMsg for incorrect input, which is great for user experience
- While using + to concatenate strings works, it's generally cleaner to use template literals (backticks) in modern JavaScript. It will make your code easier to read:
alert(`Hi ${customerName}! What are you craving today?`)
- Currently, the while loop relies on an empty string check to keep prompting the user. It might be cleaner and safer to check if the input is one of the valid options directly.
Overall, really good job with this project - these are just some things to consider going forward ⭐
| while (isNaN(age) == true || age < 1 || 100 < age) { | ||
| age = prompt("How old are you?", "Please type your age here") | ||
| if (isNaN(age) == true || age < 1 || 100 < age) { | ||
| alert("Please enter a valid age.") |
There was a problem hiding this comment.
Haha what if I'm really old 👀
| let foodType = "" | ||
| while (foodType == "") { | ||
| if (foodChoice == "Pizza") { | ||
| choice = prompt("Please enter a number: \n 1 - Napolitana \n 2 - Margherita \n 3 - Sicilian", "Please type you number of choice here") |
There was a problem hiding this comment.
It would be cool if you also included something in the message like, "What type of pizza would you like?" Please enter a number.....🤩
Comment on lines
+15
to
+26
| while (foodChoice == "") { | ||
| let choice = prompt("Please enter a number: \n 1 - Pizza \n 2 - Pasta \n 3 - Salad", "Please type you number of choice here") | ||
| if (choice == 1) { | ||
| foodChoice = "Pizza" | ||
| } else if (choice == 2) { | ||
| foodChoice = "Pasta" | ||
| } else if (choice == 3) { | ||
| foodChoice = "Salad" | ||
| } else { | ||
| alert(errMsg) | ||
| } | ||
| } |
There was a problem hiding this comment.
The loop was really cool! Nice that you get back to the same question again if you type the wrong answer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://precious-zabaione-04568c.netlify.app/