Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MellowList #441

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

MellowList #441

wants to merge 27 commits into from

Conversation

cpz-crafts
Copy link

@cpz-crafts cpz-crafts commented Apr 23, 2023

Copy link

@dannebrob dannebrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Carol! It fulfills all requirements of blue level, and beyond. Be proud! I like the design and nice addition with the playlist on top, I liked that alot.

}

const getDueDate = (date) => {
switch (date) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use case of switch / case


import { createSlice } from '@reduxjs/toolkit';

export const playlist = createSlice({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting way to store the Spotify link, any reason why you did it like this? Want to add more playlists?

import { createSlice } from '@reduxjs/toolkit';

const getInitialState = () => {
const projectsFromLocalStorage = JSON.parse(localStorage.getItem('projectsList'));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation of localStorage

<meta property="og:title" content="MellowList" />
<meta property="og:description" content="Get in the zone and conquer your to-do list" />
<meta property="og:url" content="https://peppy-stroopwafel-0a74de.netlify.app/" />
<meta property="og:type" content="website" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you added meta data :D


return (
<PlaylistContainer>
<span>{name}</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add css rule to display: none on smaller screen-sizes for a more clean look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants