Project to-do-list #450
Open
Project to-do-list #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
April 24, 2023 10:23
Comment on lines
+1
to
+70
| import React, { useState } from 'react'; | ||
| import { useDispatch } from 'react-redux'; | ||
| import tasks from 'components/reducers/tasks'; | ||
| import styled from 'styled-components'; | ||
|
|
||
| const InnerWrapper = styled.div` | ||
| display: flex; | ||
| flex-directon: row; | ||
| justify-content: center; | ||
| align-items: center; | ||
| ` | ||
| const Label = styled.div` | ||
| font-size: 20px; | ||
| ` | ||
|
|
||
| const Input = styled.input` | ||
| width: 200px; | ||
| height: 30px; | ||
| border-radius: 5px; | ||
| border: solid rgb(86, 113, 143); | ||
| margin-right: 10px; | ||
| font-size: 18x; | ||
| ` | ||
|
|
||
| const SubmitBtn = styled.button` | ||
| width: 50px; | ||
| height: 40px; | ||
| margin-left: -9px; | ||
| border-style: none; | ||
| background-color: rgb(187, 205, 226); | ||
| font-size: 15px; | ||
| color: rgb(86, 113, 143); | ||
| position: absolute; | ||
| ` | ||
| const AddTask = () => { | ||
| const [inputValue, setInputValue] = useState('') | ||
| const dispatch = useDispatch() | ||
| const onFormSubmit = (event) => { | ||
| event.preventDefault(); | ||
| const newTask = { | ||
| id: Date.now().toString(), | ||
| text: inputValue, | ||
| complete: false | ||
| } | ||
| dispatch(tasks.actions.addTask(newTask)); | ||
| setInputValue(''); | ||
| } | ||
|
|
||
| return ( | ||
| <InnerWrapper> | ||
| <form onSubmit={onFormSubmit}> | ||
| <Label htmlFor="addInput"> | ||
| <Input | ||
| value={inputValue} | ||
| type="text" | ||
| placeholder="Don't forget to bring..." | ||
| onChange={(event) => setInputValue(event.target.value)} | ||
| id="addInput" /> | ||
| <SubmitBtn type="submit" disabled={inputValue.length === 0}> | ||
| <span className="material-symbols-outlined"> | ||
| local_mall | ||
| </span> | ||
| </SubmitBtn> | ||
| </Label> | ||
| </form> | ||
| </InnerWrapper> | ||
| ) | ||
| } | ||
|
|
||
| export default AddTask; |
There was a problem hiding this comment.
Well structured and easy to read!
Comment on lines
+80
to
+127
| {completedTask.map((task) => { | ||
| return ( | ||
| <InnerWrapper> | ||
| <label htmlFor={task.id}> | ||
| <input | ||
| key={task.id} | ||
| type="checkbox" | ||
| checked={task.isChecked} | ||
| onChange={() => dispatch(tasks.actions.toggleItem(task))} /> | ||
| </label> | ||
| <TaskText> | ||
| {task.text} | ||
| </TaskText> | ||
| <DeleteBtn | ||
| type="button" | ||
| onClick={() => dispatch(tasks.actions.deleteTask(task))}> | ||
| <span className="material-symbols-outlined"> | ||
| local_laundry_service | ||
| </span> | ||
| </DeleteBtn> | ||
| </InnerWrapper> | ||
| ) | ||
| })} | ||
| <ListHeaderHome><h2>Home</h2> | ||
| </ListHeaderHome> | ||
| {taskToDo.map((task) => { | ||
| return ( | ||
| <InnerWrapper> | ||
| <label htmlFor={task.id}> | ||
| <input | ||
| type="checkbox" | ||
| checked={task.isChecked} | ||
| key={task.id} | ||
| onChange={() => dispatch(tasks.actions.toggleItem(task))} /> | ||
| </label> | ||
| <TaskText> | ||
| {task.text} | ||
| </TaskText> | ||
| <DeleteBtn | ||
| type="button" | ||
| onClick={() => dispatch(tasks.actions.deleteTask(task))}> | ||
| <span className="material-symbols-outlined"> | ||
| local_laundry_service | ||
| </span> | ||
| </DeleteBtn> | ||
| </InnerWrapper> | ||
| ) | ||
| })} |
There was a problem hiding this comment.
maybe the return from mapping of completedTask and TaskToDo could have been a reusable component since they return the same type of content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to project: https://backandforthlist.netlify.app/