Styling - adding favicon #452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +13,10 @@ | |||
| Learn how to configure a non-root public URL by running `npm run build`. | |||
| --> | |||
| <title>Technigo React App</title> | |||
| <link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | |||
| <link rel="icon" href="favicon.svg" type="image/svg+xml" /> | |||
| import plus from '../img/plus.png'; | ||
|
|
||
| function getOrdinalSuffix(day) { | ||
| if (day >= 11 && day <= 13) { |
There was a problem hiding this comment.
Whats happening here? Make a comment to this maybe?
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "short_name": "ToDO", | |||
| "name": "ToDo", | |||
There was a problem hiding this comment.
Hey Malvina!
Great work with this To-Do list! Everything works like it was intended to.
The page showed up properly and did not crash or act strange in any situation that I could see. The requirements was to make to-do-list with posts that was listed and that individually could be deleted and also a button that cleared the whole list and you made that. Nice with the icons too! The code is well-structured Nice and clear! You make descriptive notes on most places. It would be nice to have even more of them i think! Nice work Malwina!
I will drop some single comments in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.