Added Tuple for message contents #11
Conversation
We may use tuple[T1, ..., Tn] to indicate a tuple type
|
Hi @Ahmet-Kaplan, Thank you for suggesting this modification for type hinting! See if you can fix this patch according to my suggestions and include changes to all the type annotations. In addition, if you are willing to help us go through the repo and make sure type annotations are consistent throughout all the modules, it can be super helpful! |
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| from dataclasses import dataclass | |||
| from enum import Enum | |||
| from typing import NamedTuple, Optional, List | |||
| from typing import NamedTuple, Optional, List, Tuple | |||
There was a problem hiding this comment.
we want to move to the built-in (python 3.9 +) collection type hints/annotations. So instead of importing them from typing, using the built-in type annotations.
| @@ -128,7 +128,7 @@ def pretty_repr(self, number: Optional[int] = None, conversation_name: str = '', | |||
| s += colored_text(sep * TEXT_WIDTH, text_color) | |||
| return s | |||
|
|
|||
| def get_content_after_hiding_incomplete_code(self) -> (str, bool): | |||
| def get_content_after_hiding_incomplete_code(self) -> Tuple[str, bool]: | |||
There was a problem hiding this comment.
replace Tuple[str, bool] with tuple[str, bool]
We may use tuple[T1, ..., Tn] to indicate a tuple type