Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier support and enforce with commit hook #89

Open
vegetabill opened this issue Sep 16, 2020 · 2 comments
Open

Add prettier support and enforce with commit hook #89

vegetabill opened this issue Sep 16, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@vegetabill
Copy link
Collaborator

vegetabill commented Sep 16, 2020 •
edited by alodahl
Loading

If we're planning on a lot of different contributions, it might be nice to have a consistent format for the code.

See comments below for more info.
@alodahl alodahl added good first issue Good for newcomers GraceHopperOSD Reserved for GHC Open Source Day! Priority 1 Do first! labels Sep 20, 2020
@vegetabill
Copy link
Collaborator Author

This guide covers what we might want (except we won't need any of the React-related plugins):

https://medium.com/@loclghst/set-up-eslint-prettier-and-pre-commit-hooks-using-husky-for-react-73e7a51cda26

Feel free to use a different strategy if you know of a simpler one.

@vegetabill vegetabill changed the title Add prettier support and enforce with hook Add prettier support and enforce with commit hook Sep 25, 2020
@vegetabill vegetabill mentioned this issue Sep 25, 2020
Open
@swarna-gopalan
Copy link

@vegetabill - I can take this one as part of GraceHopperOSD

@swarna-gopalan swarna-gopalan mentioned this issue Oct 1, 2020
Closed
@vegetabill vegetabill mentioned this issue Oct 2, 2020
Closed
@alodahl alodahl removed GraceHopperOSD Reserved for GHC Open Source Day! Priority 1 Do first! labels Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #89 - Add prettier support swarna-gopalan/keyboard-shortcuts-practice
3 participants
@vegetabill @swarna-gopalan @alodahl