Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux/arm64 platform to Docker build #17

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

PCatinean
Copy link
Contributor

No description provided.

@PCatinean PCatinean force-pushed the arm64-builds branch 2 times, most recently from 7c35442 to d5c1e48 Compare February 5, 2024 11:43
@PCatinean
Copy link
Contributor Author

Rebased on #14 so pre-commit passes

@pedrobaeza
Copy link
Member

Please do a rebase over main branch for leaving only 1 commit.

@PCatinean
Copy link
Contributor Author

@pedrobaeza done

@pedrobaeza pedrobaeza merged commit b1db569 into Tecnativa:master Feb 5, 2024
3 checks passed
@PCatinean
Copy link
Contributor Author

@pedrobaeza it seems the pipeline has failed with "Error: Error response from daemon: login attempt to https://registry-1.docker.io/v2/ failed with status: 503 Service Unavailable". Not sure if it's just a glitch which works on retry of the pipeline or maybe an update on the github actions is needed

@PCatinean
Copy link
Contributor Author

@pedrobaeza thanks for the merge and pipeline re-run, seems it worked and pushed but it tagged it with :edge https://github.com/tecnativa/docker-whitelist/pkgs/container/docker-whitelist. This means arm users would need to use a different tag for the odoo_proxy service and the one from copier will not work out of the box. Not sure if you need to manually set the tag to latest or if this should be included in the CI/CD pipeline 🤷‍♂️

@PCatinean PCatinean deleted the arm64-builds branch February 5, 2024 18:02
@pedrobaeza
Copy link
Member

Learnt on the fly how this goes (doing a tag on the repository itself). There's a weird unknown/unknown architecture now, but I think it's not a big deal.

@PCatinean
Copy link
Contributor Author

Yes I saw that too and also thought it was strange. In any case it seems to work well now with the latest tag, thanks!

@PCatinean PCatinean mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants