[FIX] direxec should not try to execute directories #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap-wtioit
force-pushed
the
master-fix_entrypointd_python_github
branch
2 times, most recently
from
6915fe6
to
83212fa
Compare
ap-wtioit
changed the title
|
Updated the merge request to reflect the information gathered by the investigation of the #509 issue after discovering and fixing the cause. |
|
Can you please rebase? |
ap-wtioit
force-pushed
the
master-fix_entrypointd_python_github
branch
from
83212fa
to
76e8ce3
Compare
|
rebased and all checks still passing |
pedrobaeza
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f931b53 direxec was converted from bash to python. In the python version we should not try to execute directories. As the execute flag for directories only means that the user can change into the directory not that the directory is an executable.
This happens when a user adds a custom python script to entrypoint.d and runs doodba built with
COMPILE: "true". for this case a__pycache__directory is created in/opt/odoo/custom/entrypoint.d/that causes the following error:Info @wt-io-it