Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Not testing Doodba 18.0 to be able to push image #628

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

josep-tecnativa
Copy link
Contributor

CC @Tecnativa TT51095

@ap-wtioit
Copy link
Contributor

@josep-tecnativa on our CI we first build images with a ci-nnnn- prefix and push them, then test them, and if the tests pass we tag them as the new images. would this workflow also work with github / dockerhub?

the other thing i discovered that might be related to the issues. in docker compose for about a year (when we switched from docker-compose to docker compose) it was no longer possible for us to use local only images that had a / in the name. so we needed to push the images to our registry first to be able to test them. testing a local copy of our.regsitry/path/to/doodba:nn.0-onbuild was no longer possible, it needed an image in the registry first.

@josep-tecnativa
Copy link
Contributor Author

I believe that workflow would indeed work with GitHub and Docker Hub. Once I finish updating to Doodba 18.0, I'll proceed with implementing it, as I see it as a very clean solution. Thank you!

@josep-tecnativa josep-tecnativa merged commit 3706d99 into master Oct 8, 2024
12 checks passed
@josep-tecnativa josep-tecnativa deleted the avoid-18.0-test branch October 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants