-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add child diagnostics #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to do the work, good job! I've put some feedback, feel free to take it or not :)
bc2a286
to
cd9a108
Compare
@AlisCode thanks for the great review so far! The area that I would most appreciate help with on this is coming up with some unit tests; these would serve as a sanity check for the functionality and catch ergonomic issues like the one about being able to pass string literals without needing
|
I'll see what I can do for the unit-test coverage of this, although I don't immediately see a good solution to the panic. Thanks for the reactivity and the good work ! |
@AlisCode Rather than always pinning nightly, I'd suggest adding a specific new job that tests diagnostics with that feature enabled and the nightly version pinned. That'll avoid changing the current test slate which runs against the latest nightly. I think the best solution for the panic issue is to manually test
Thanks for the great feature request! |
cd9a108
to
e9c88ba
Compare
When using the `diagnostics` feature, crate consumers can add custom error, warning, note, and help messages to `Error` instances and have those appear in the compiler's output. Fixes #224
e9c88ba
to
6a616d6
Compare
@AlisCode the doc tests I added seem to do a good enough job of making sure the happy-path compiles, so I'm going to declare this "good enough for a feature-flagged feature" and merge. |
Fixes #224
Open Items