-
Notifications
You must be signed in to change notification settings - Fork 3
markdown-confluence-sync: DryRun option #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check SPDX headers ✅ 242 files have valid headers. |
|
Check License Compliance ✅ There are 1434 dependencies with allowed licenses.
✅ Result: Valid licenses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new dryRun option to markdown-confluence-sync, enabling users to run a configuration test without sending changes to Confluence.
- Adds unit tests and component tests to verify the dryRun behavior.
- Enhances the configuration types and option definitions to support a dry run mode.
- Updates documentation, changelog, and versioning to reflect the new feature.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/markdown-confluence-sync/test/unit/specs/MarkdownConfluenceSync.test.ts | Added a unit test ensuring no synchronization call is made in dryRun mode |
| components/markdown-confluence-sync/test/component/specs/dryRun.spec.ts | Added component tests to validate exit code and log output in dryRun mode |
| components/markdown-confluence-sync/test/component/fixtures/dry-run/markdown-confluence-sync.config.cjs | Introduced configuration for dryRun testing |
| components/markdown-confluence-sync/src/lib/MarkdownConfluenceSync.types.ts | Defined types for the dryRun option |
| components/markdown-confluence-sync/src/lib/MarkdownConfluenceSync.ts | Integrated the dryRun option into the sync flow with a conditional early return |
| components/markdown-confluence-sync/README.md | Documented the new dryRun option |
| components/markdown-confluence-sync/CHANGELOG.md | Logged the addition of the dryRun feature |
Comments suppressed due to low confidence (2)
components/markdown-confluence-sync/src/lib/MarkdownConfluenceSync.ts:172
- [nitpick] Consider clarifying in the documentation the distinction between the global 'dryRun' option and 'confluence.dryRun' to avoid potential user confusion.
const dryRun = this._dryRunOption.value;
components/markdown-confluence-sync/test/unit/specs/MarkdownConfluenceSync.test.ts:45
- [nitpick] Ensure that 'customConfluenceSync' is properly mocked so that the test reliably validates that no synchronization is attempted when dryRun is enabled.
expect(customConfluenceSync.sync).not.toHaveBeenCalled();
JavierIbanezSoloaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
markdown-confluence-sync: DryRun option
Description
dryRunoption to markdown-confluence-sync, enabling to run the sync process without actually sending the content to Confluence. This is useful for testing the configuration and markdown files without making changes in Confluence.closes #57
Agreement
Please check the following boxes after you have read and understood each item.
In case this is your first contribution to this project, you will also have to add a comment with the following text: "I have read the CLA Document and I hereby sign the CLA", otherwise the PR status will fail and our bot will request you to add it. Once you have signed it in a PR, you will not have to sign it again for future contributions.