-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Support different authentication methods #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tests to check the whole feature
|
Check SPDX headers ✅ 245 files have valid headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for multiple authentication methods (OAuth2, Basic, JWT) to the confluence-sync and markdown-confluence-sync libraries, while deprecating the personalAccessToken option in favor of a more flexible authentication configuration object.
Key changes:
- Added new authentication options (OAuth2, Basic, JWT) and deprecated
personalAccessToken - Updated confluence.js dependency from 1.7.4 to 2.1.0 to support pagination options for retrieving child pages
- Improved error handling and messaging throughout the codebase
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/confluence-sync/src/confluence/CustomConfluenceClient.ts | Adds authentication type guards and refactors client initialization to support multiple auth methods with backward compatibility |
| components/confluence-sync/src/confluence/CustomConfluenceClient.types.ts | Defines new authentication configuration types for OAuth2, Basic, and JWT methods |
| components/confluence-sync/src/confluence/errors/*.ts | Refactors error classes to extend CustomError and improves error message handling |
| components/markdown-confluence-sync/src/lib/confluence/ConfluenceSync.ts | Adds authentication option handling and deprecation warning for personalAccessToken |
| components/*/README.md | Updates documentation with new authentication configuration examples |
| components/*/CHANGELOG.md | Documents the new features and changes |
| components/*/test/** | Updates tests to cover new authentication methods and error handling |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Check License Compliance ✅ There are 1450 dependencies with allowed licenses.
✅ Result: Valid licenses |
Support different authentication methods
Description
confluence-sync
markdown-confluence-sync
dev tools
closes #56
Agreement
Please check the following boxes after you have read and understood each item.
In case this is your first contribution to this project, you will also have to add a comment with the following text: "I have read the CLA Document and I hereby sign the CLA", otherwise the PR status will fail and our bot will request you to add it. Once you have signed it in a PR, you will not have to sign it again for future contributions.