Skip to content

Conversation

@dhonti-axpe
Copy link
Contributor

@dhonti-axpe dhonti-axpe commented Dec 30, 2025

🎟️ Jira ticket

ANDROID-16934

🥅 What's the goal?

  • Global task: Remove Databinding from Mistica in library module and the corresponding components.

This PR is a part of this three:

After all these PRs are merged, a final one will be created to remove the Data Binding feature from the build.gradle file.

🚧 How do we do it?

Remove BindingMethods, InverseBindingMethod and BindingAdapters methods and update corresponding README files from next components:
* button2/Button
* CalloutView
* CardView
* DataCardView
* MediaCardView
* EmptyStateCardView
* EmptyStateScreenView

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Only affects Android side.
  • Accessibility considerations.

🧪 How can I test this?

As is mentioned in the corresponding ANDROID-16934 ticket, is tested in the "android-messenger" client project that the total PR changes exposed in #476 works correctly.

@github-actions
Copy link

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

@dhonti-axpe dhonti-axpe changed the title Android 16934/pr1 remove databinding ANDROID-16934 -- (I) Remove databinding related code Jan 4, 2026
@dhonti-axpe dhonti-axpe self-assigned this Jan 13, 2026
@dhonti-axpe dhonti-axpe marked this pull request as ready for review January 13, 2026 12:25
@dhonti-axpe dhonti-axpe requested review from a team, dnieto-r and jeslat and removed request for a team January 13, 2026 12:25
Copy link
Contributor

@jeslat jeslat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@dnieto-r dnieto-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dhonti-axpe dhonti-axpe merged commit a36b490 into ANDROID-16934/base-remove-databinding Jan 14, 2026
4 checks passed
@dhonti-axpe dhonti-axpe deleted the ANDROID-16934/pr1-remove-databinding branch January 14, 2026 09:24
dhonti-axpe added a commit that referenced this pull request Jan 20, 2026
* ANDROID-16934 -- (III) Remove databinding related code (#480)

* ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TextLink" component

* ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "ListRowView" and "MisticaRecyclerView" components and update the corresponding README file

* ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "DeterminateStepperView" and "IndetermianteStepperView" components

* ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TitleView" component

* ANDROID-16934/pr3-remove-databinding: Update correct word in README file

* ANDROID-16934 -- (I) Remove databinding related code  (#478)

* ANDROID-16934/pr1-remove-databinding: Remove databinding references from "button2/Button" component

* ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CalloutView" components and update corresponding README file

* ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CardView" components and update corresponding REDME file

* ANDROID-16934/pr1-remove-databinding: Remove databinding references form "EmptyState" components and update corresponding README files

* ANDROID-16934/pr1-remove-databinding: Revert some extra spaces

* ANDROID-16934/pr1-remove-databinding: Remove some extra space from "DataCardView"

* ANDROID-16934/pr1-remove-databinding: Revert some lint space changes

* ANDROID-16934 -- (II) Remove databinding related code  (#479)

* ANDROID-16934/pr2-remove-databinding: Remove databinding method from "LoadErrorFeedabackView" component and update corresponding README file.

* ANDROID-16934/pr2-remove-databinding: Update README file from "feedback/screen" component

* ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HeaderView" component and update corresponding README file

* ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HighlightedCardView" component and update its corresponding README file.

* ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "Input", "TextInput" and expose some attributes also from "CheckBoxInput" components, updating their corresponding README files

* ANDROID-16934/pr2-remove-databinding: Remove unused imports from "TextInput" component

* ANDROID-16934/pr2-remove-databinding: Remove duplicate line

* ANDROID-16934/pr2-remove-databinding: Fix grammar in README file

* ANDROID-16934/pr4-remove-databinding: (#482)

- Remove databinding feature and kapt (used by first one)
- Replace implementation by "api" in "androidx.compose.ui" library

* ANDROID-16934/pr5-remove-databinding: Update some rest components: (#483)

- Remove some old comments
- Update forgotten "buttonOnClick" component necessary in attrs_components
- Update correctly "LoadErrorFeedbackView" component

* ANDROID-16934/base-remove-databinding: Remove unused attribute from "button2/Button" component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants