-
Notifications
You must be signed in to change notification settings - Fork 5
ANDROID-16934 -- (I) Remove databinding related code #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROID-16934 -- (I) Remove databinding related code #478
Conversation
…rom "button2/Button" component
…rom "CalloutView" components and update corresponding README file
…rom "CardView" components and update corresponding REDME file
…orm "EmptyState" components and update corresponding README files
|
[Firebase] 📱 New catalog for testing generated: |
|
[Firebase] 📱 New catalog for testing generated: |
jeslat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dnieto-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
a36b490
into
ANDROID-16934/base-remove-databinding
* ANDROID-16934 -- (III) Remove databinding related code (#480) * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TextLink" component * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "ListRowView" and "MisticaRecyclerView" components and update the corresponding README file * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "DeterminateStepperView" and "IndetermianteStepperView" components * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TitleView" component * ANDROID-16934/pr3-remove-databinding: Update correct word in README file * ANDROID-16934 -- (I) Remove databinding related code (#478) * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "button2/Button" component * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CalloutView" components and update corresponding README file * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CardView" components and update corresponding REDME file * ANDROID-16934/pr1-remove-databinding: Remove databinding references form "EmptyState" components and update corresponding README files * ANDROID-16934/pr1-remove-databinding: Revert some extra spaces * ANDROID-16934/pr1-remove-databinding: Remove some extra space from "DataCardView" * ANDROID-16934/pr1-remove-databinding: Revert some lint space changes * ANDROID-16934 -- (II) Remove databinding related code (#479) * ANDROID-16934/pr2-remove-databinding: Remove databinding method from "LoadErrorFeedabackView" component and update corresponding README file. * ANDROID-16934/pr2-remove-databinding: Update README file from "feedback/screen" component * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HeaderView" component and update corresponding README file * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HighlightedCardView" component and update its corresponding README file. * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "Input", "TextInput" and expose some attributes also from "CheckBoxInput" components, updating their corresponding README files * ANDROID-16934/pr2-remove-databinding: Remove unused imports from "TextInput" component * ANDROID-16934/pr2-remove-databinding: Remove duplicate line * ANDROID-16934/pr2-remove-databinding: Fix grammar in README file * ANDROID-16934/pr4-remove-databinding: (#482) - Remove databinding feature and kapt (used by first one) - Replace implementation by "api" in "androidx.compose.ui" library * ANDROID-16934/pr5-remove-databinding: Update some rest components: (#483) - Remove some old comments - Update forgotten "buttonOnClick" component necessary in attrs_components - Update correctly "LoadErrorFeedbackView" component * ANDROID-16934/base-remove-databinding: Remove unused attribute from "button2/Button" component
🎟️ Jira ticket
ANDROID-16934
🥅 What's the goal?
librarymodule and the corresponding components.This PR is a part of this three:
After all these PRs are merged, a final one will be created to remove the Data Binding feature from the
build.gradlefile.🚧 How do we do it?
Remove BindingMethods, InverseBindingMethod and BindingAdapters methods and update corresponding README files from next components:
* button2/Button
* CalloutView
* CardView
* DataCardView
* MediaCardView
* EmptyStateCardView
* EmptyStateScreenView
☑️ Checks
🧪 How can I test this?
As is mentioned in the corresponding ANDROID-16934 ticket, is tested in the "android-messenger" client project that the total PR changes exposed in #476 works correctly.