Skip to content

Conversation

@dhonti-axpe
Copy link
Contributor

@dhonti-axpe dhonti-axpe commented Jan 16, 2026

🎟️ Jira ticket

ANDROID-16934

🥅 What's the goal?

After applying following previous PRs:

Is fully remove DataBinding usage from the Mística library and align its Gradle configuration with the new Jetpack Compose–based architecture, ensuring proper dependency propagation to consumer projects (android-messenger and SmartWifi).

🚧 How do we do it?

In previous PRs about this main feature, was forgotten:

  • Include the corresponding update about LoadErrorFeedbackView component.
  • Include in attrs_components.xml the buttonOnClick parameter in button2/Button component
  • Remove old comment and update main CONTRIBUTING.md file, deleting databinding references.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Only affects Android side.
  • Accessibility considerations.

🧪 How can I test this?

As is mentioned in the corresponding ANDROID-16934 ticket, is tested in the "android-messenger" client project that the total PR changes exposed in #476 works correctly.

- Remove some old comments
- Update forgotten "buttonOnClick" component necessary in attrs_components
- Update correctly "LoadErrorFeedbackView" component
@dhonti-axpe dhonti-axpe self-assigned this Jan 16, 2026
@github-actions
Copy link

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

@dhonti-axpe dhonti-axpe requested review from a team, jeprubio and jeslat and removed request for a team January 19, 2026 07:04
@dhonti-axpe dhonti-axpe marked this pull request as ready for review January 19, 2026 07:09
@dhonti-axpe dhonti-axpe merged commit 5b33b54 into ANDROID-16934/base-remove-databinding Jan 19, 2026
4 checks passed
@dhonti-axpe dhonti-axpe deleted the ANDROID-16934/pr5-remove-databinding branch January 19, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants