ANDROID-16934 -- (II) Remove databinding related code #479
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,97 +15,13 @@ import androidx.annotation.ColorInt | |||||||
| import androidx.annotation.LayoutRes | ||||||||
| import androidx.annotation.StringRes | ||||||||
| import androidx.core.graphics.drawable.toDrawable | ||||||||
| import com.telefonica.mistica.R | ||||||||
| import com.telefonica.mistica.util.children | ||||||||
| import com.telefonica.mistica.util.convertDpToPx | ||||||||
| import com.telefonica.mistica.util.getMisticaThemeDrawable | ||||||||
| import com.telefonica.mistica.util.getThemeColor | ||||||||
| import com.telefonica.mistica.util.setTextAndVisibility | ||||||||
|
|
||||||||
| class HeaderView @JvmOverloads constructor( | ||||||||
| context: Context, | ||||||||
| attrs: AttributeSet? = null, | ||||||||
|
|
@@ -319,6 +235,36 @@ class HeaderView @JvmOverloads constructor( | |||||||
| configureTextsColors() | ||||||||
| } | ||||||||
|
|
||||||||
| fun setHeaderFirstPretitle(@StringRes textRes: Int?) = setFirstPretitle(textRes) | ||||||||
| fun setHeaderTitle(text: CharSequence?) = setTitle(text) | ||||||||
|
|
||||||||
| fun setHeaderInverse(value: Boolean) = setInverse(value) | ||||||||
| fun setHeaderHasTopPadding(value: Boolean) = setHasTopPadding(value) | ||||||||
|
|
||||||||
| fun setHeaderFirstPretitle(text: CharSequence?) = setFirstPretitle(text) | ||||||||
| fun setHeaderFirstPretitleHasSecondaryColor(value: Boolean) = | ||||||||
| setFirstPretitleHasSecondaryColor(value) | ||||||||
|
|
||||||||
| fun setHeaderSecondPretitle(text: CharSequence?) = setSecondPretitle(text) | ||||||||
| fun setHeaderSecondPretitleHasSecondaryColor(value: Boolean) = | ||||||||
| setSecondPretitleHasSecondaryColor(value) | ||||||||
|
|
||||||||
| fun setHeaderNumeral(text: CharSequence?) = setNumeral(text) | ||||||||
| fun setHeaderNumeralHasErrorColor(value: Boolean) = setNumeralHasDangerColor(value) | ||||||||
|
|
||||||||
| fun setHeaderSubtitle(text: CharSequence?) = setSubtitle(text) | ||||||||
| fun setHeaderSubtitleHasSecondaryColor(value: Boolean) = setSubtitleHasSecondaryColor(value) | ||||||||
|
|
||||||||
| fun setHeaderActionButtonText(text: CharSequence?) = setActionButtonText(text) | ||||||||
| fun setHeaderSecondaryActionButtonText(text: CharSequence?) = setSecondaryActionButtonText(text) | ||||||||
|
There was a problem hiding this comment. Line exceeds 120 characters. Consider breaking this line for better readability.
Suggested change
|
||||||||
|
|
||||||||
| fun setHeaderActionButtonOnClick(listener: OnClickListener?) = setActionButtonOnClick(listener) | ||||||||
| fun setHeaderSecondaryActionButtonOnClick(listener: OnClickListener?) = | ||||||||
| setSecondaryActionButtonOnClick(listener) | ||||||||
|
|
||||||||
| fun setHeaderBottomLayout(@LayoutRes layoutRes: Int) = setBottomLayout(layoutRes) | ||||||||
|
|
||||||||
|
|
||||||||
| private fun configureTextsColors() { | ||||||||
| val backgroundDrawable = if (isInverse) { | ||||||||
| context.getMisticaThemeDrawable(R.attr.drawableBackgroundBrand) | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,36 +7,12 @@ import android.text.method.MovementMethod | |
| import android.util.AttributeSet | ||
| import android.view.LayoutInflater | ||
| import android.widget.CompoundButton | ||
| import androidx.annotation.StringRes | ||
| import androidx.appcompat.widget.AppCompatCheckBox | ||
| import com.google.android.material.textfield.TextInputLayout | ||
| import com.telefonica.mistica.R | ||
| import com.telefonica.mistica.util.getThemeColor | ||
|
|
||
| class CheckBoxInput @JvmOverloads constructor( | ||
| context: Context, | ||
| attrs: AttributeSet? = null, | ||
|
|
@@ -102,6 +78,28 @@ class CheckBoxInput @JvmOverloads constructor( | |
| checkBox.buttonTintList = ColorStateList(states, colors) | ||
| } | ||
|
|
||
| fun setInputError(@StringRes errorRes: Int?) { | ||
| if (errorRes == null) { | ||
| error = null | ||
| setErrorEnabled(false) | ||
| } else { | ||
| error = context.getString(errorRes) | ||
| setErrorEnabled(true) | ||
| } | ||
| } | ||
|
Comment on lines
+81
to
+89
There was a problem hiding this comment. This is a potential breaking change. The new public method setInputError(@stringres Int?) was introduced as a replacement for the removed data binding attribute 'inputError'. While this maintains functional compatibility through attribute-based configuration, consumers who were directly calling methods on CheckBoxInput instances may need to update their code if they were using the data binding setError method signature that accepted CharSequence. Please apply the 'Breaking change' label to this PR. Migration notes should be added when drafting the release.
Contributor
Author
There was a problem hiding this comment. After merging all this feature branch in Mistica, is necessary to fit current implementation in "android-messenger" incresing new Mistica version. |
||
|
|
||
| fun setInputEnabled(enabled: Boolean) { | ||
| isEnabled = enabled | ||
| } | ||
|
|
||
| fun setInputCheckText(text: CharSequence?) { | ||
| setText(text) | ||
| } | ||
|
|
||
| fun getInputCheckText(): CharSequence? { | ||
| return getText() | ||
| } | ||
|
Comment on lines
+95
to
+101
There was a problem hiding this comment. These are potential breaking changes. The new public methods setInputCheckText and getInputCheckText replace the removed data binding methods setText and getText. While these maintain functional compatibility through attribute-based configuration, the change in method naming may affect consumers who were calling these methods directly. Please apply the 'Breaking change' label to this PR. Migration notes should be added when drafting the release.
Contributor
Author
There was a problem hiding this comment. Same like previous one |
||
|
|
||
| fun setChecked(checked: Boolean) { | ||
| checkBox.isChecked = checked | ||
| } | ||
|
|
@@ -131,14 +129,4 @@ class CheckBoxInput @JvmOverloads constructor( | |
| super.setEnabled(enabled) | ||
| checkBox.isEnabled = enabled | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate method definition for setHeaderFirstPretitle. Line 238 accepts @stringres Int? while line 244 accepts CharSequence?. This creates a naming collision that will cause compilation errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently these methods do not launch any compilation errors due to signature is different.