Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors to console when reserved keys are being used by users #197

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Nov 1, 2024

Fixes #185.

Apart from the keys specified in the task (which I assume to be server-side) I also added all default parameters we've been reporting and auto-creating insights for. Those should also not be overridden to ensure correct stats in our built-in charts.

@Jeehut Jeehut requested a review from winsmith November 1, 2024 14:27
@Jeehut Jeehut merged commit 1e26fea into main Nov 4, 2024
6 checks passed
@Jeehut Jeehut deleted the feature/reserved-keys branch November 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when using a reserved name in Parameters
2 participants