Skip to content

docs: document degraded-filtering fallback path for event topics #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joan-bisbal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: document degraded-filtering fallback path for event topics #349

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a82d9a
refactor: optimize event topic filtering logic
joan-bisbal Jul 27, 2026
a2c0f97
refactor: add indexed topic lookup architecture specification for eve…
joan-bisbal Jul 29, 2026
76babe5
docs: document degraded-filtering fallback path for event topics
joan-bisbal Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/event_topic_filtering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Event Topic Filtering Optimization

Replaces linear topic scans with indexed lookup table for faster event parsing.

@Depo-dev Depo-dev Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is refactor: optimize event topic filtering logic and the file claims it "replaces linear topic scans with indexed lookup table", but nothing in this diff touches the filtering code — it is a three-line description of a change that was not made.

The actual code is in crates/indexer/src/streamer/mod.rs (plan_filters, and the topic handling in poll_once), with the RPC-side filters in crates/indexer/src/rpc/mod.rs. Note that topic filtering is already pushed server-side into the getEvents RPC call via EventFilter (issue #203), so before optimising anything locally it is worth measuring whether the linear scan is actually on a hot path.

If there is a real win there, a PR containing the code change plus a benchmark or test demonstrating it would be very welcome. Please also target dev rather than main, and drop the UTF-8 BOM.

Loading