-
Notifications
You must be signed in to change notification settings - Fork 58
Create developer dashboard — event browser UI #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenkenseb
wants to merge
3
commits into
Telocel-Labs:dev
Choose a base branch
from
kenkenseb:developer-dashboard-—-event-browser-UI
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "developer-dashboard-\u2014-event-browser-UI"
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| https://www.figma.com/design/OhOGPhmbRZM9rlYWENffXf/Untitled?node-id=0-1&t=UWpCsnybapHNpwFz-1 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a single file containing one Figma URL and no code, but the description and title present it as an implemented dashboard (real-time event feed, slide-over JSON drawer, donut gauge for ledger lag, API key management). None of that exists in this diff.
Three concrete problems:
Closes #76would auto-close an unimplemented feature. Issue feat(infra): developer dashboard — event browser UI #76 (feat(infra): developer dashboard — event browser UI) is still open and unbuilt. Merging this closes it while shipping nothing, which silently corrupts the backlog.The file itself shouldn't be committed. The filename has spaces and an em-dash with no extension (
developer dashboard — event browser UI). That breaks shell globbing and tooling on most platforms, and a bare URL in a repo file goes stale the moment the Figma doc moves.A Figma link isn't reviewable as code. There's nothing here to check for correctness, accessibility, or integration with the existing stack.
The design work itself may well be good — the problem is purely the delivery channel. Please close this PR and post the Figma link as a comment on #76 instead, keeping the issue open. If the intent is to actually build the dashboard, open a fresh PR with the implementation and link the design from the description.
Worth flagging: there's currently no accepted home for design deliverables in this repo, which is probably why this landed as a PR. That's on us, not you — I've logged it as a gap to fix.