Repository navigation
fix(mcp-server): pin MCP Python SDK to v1.x - #2395
Merged
Merged
Conversation
WeKnora MCP Server still uses v1 low-level Server decorators such as @app.list_tools(). MCP SDK 2.0 removed those APIs, so fresh installs could fail at startup with AttributeError. Cap the dependency at <2 and require >=1.28 for Streamable HTTP transport support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpto>=1.28,<2inrequirements.txt,pyproject.toml, andsetup.pyfallback deps.pyproject.tomlwith HTTP transport runtime deps (starlette,uvicorn).mcp-server/CHANGELOG.md.Why
WeKnora MCP Server still uses MCP Python SDK v1 low-level
Serverdecorators such as@app.list_tools(). MCP SDK 2.0 removed those APIs, so freshpip install/uv syncinstalls can fail at startup with:The lower bound
1.28keeps Streamable HTTP transport (StreamableHTTPSessionManager) available.Test plan
uv pip install 'mcp>=1.28,<2'resolves to a 1.x releaseimport weknora_mcp_serversucceeds on MCP SDK 1.xpython main.py --transport httpstarts and serves/mcp