Repository navigation
fix(embedding): reject non-positive batch sizes before pooling - #4870
Merged
Merged
Conversation
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting
BATCH_EMBED_SIZEto 0 or a negative integer currently makesBatchEmbedWithPoolpanic inutils.ChunkSlice, rather than returning an error to ingestion or Wiki callers.Validate the parsed value before mapping inputs or submitting work to the pool. Invalid values now return a configuration error with no provider requests. Positive values, the default batch size of 5, and existing integer-parse errors retain their current behavior.
The production fix is three lines and adds no shared state, dependencies or API fields.
Type of Change
Related Issue
None; found while checking batch configuration handling. This does not change the retry/pacing work in #4127.
Testing
TestPoolRejectsInvalidBatchSizefailed withchunkSize must be greater than 0for both0and-1.go test ./internal/models/embedding -count=1 -timeout=2mgo test -race ./internal/models/embedding -count=1 -timeout=2mgo vet ./internal/models/embeddinggo build ./internal/models/embeddinggolangci-lint run --new-from-rev=origin/main --timeout=5m ./internal/models/embedding(v2.12.2; 0 issues).Checklist
git diff --check origin/main...HEADpassesDocumentation and screenshots: not applicable. Total diff: +29/-0 (29 changed lines including tests).