fix issue: no member named create_gpu_instance in namespace ncnn #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nihui
requested changes
Jun 4, 2024
Comment on lines
+4556
to
+4559
| int create_gpu_instance(const char* driver_path) | ||
| { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Use NCNN_LOGE to warn users that ncnn has not been compiled with Vulkan support, and CPU computation will always be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intent to fix following issue:
This issue could be reproduced very easily with official release pkg ncnn-20240410-android-vulkan.zip.
the root-cause is that NCNN_VULKAN was defined/hard-coded by CMake build script and many NCNN's internal codes heavily depend on the pre-defined/hard-coded NCNN_VULKAN, but some NCNN GPU APIs(such as create_gpu_instance, destroy_gpu_instance, get_gpu_count...) would be called in user's code even the scenario is pure CPU inference.