Skip to content

Conversation

@nihui
Copy link
Member

@nihui nihui commented Jan 6, 2026

No description provided.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (6bc338e) to head (ad9303a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6491      +/-   ##
==========================================
- Coverage   93.40%   92.98%   -0.42%     
==========================================
  Files         845      845              
  Lines      264353   264650     +297     
==========================================
- Hits       246911   246079     -832     
- Misses      17442    18571    +1129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the python label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds wchar_t (wide character) versions of the net load API functions for Windows to support file paths with non-ASCII characters. It also includes minor test updates to copy additional layer support flags.

  • Adds load_param(const wchar_t*), load_param_bin(const wchar_t*), and load_model(const wchar_t*) methods for Windows in the Net class
  • Exposes these new methods through the C API with _w suffixes
  • Updates Python bindings to use std::wstring on Windows
  • Updates test code to copy support_any_packing and support_vulkan_any_packing flags

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/net.h Declares wchar_t overloads for load_param, load_param_bin, and load_model methods on Windows
src/net.cpp Implements wchar_t overloads using _wfopen for Windows file access
src/c_api.h Declares C API functions with _w suffix for wchar_t support on Windows
src/c_api.cpp Implements C API wrappers that call the C++ wchar_t methods
python/src/main.cpp Updates Python bindings to accept std::wstring paths on Windows
tests/test_squeezenet.cpp Copies support_any_packing and support_vulkan_any_packing flags in test layer wrapper
docs/how-to-use-and-FAQ/ncnn-load-model.md Documents the new wchar_t API variants in the load model reference table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nihui and others added 2 commits January 6, 2026 15:32
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@nihui nihui merged commit 419db5e into Tencent:master Jan 6, 2026
104 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants