-
Notifications
You must be signed in to change notification settings - Fork 4.4k
net load api wchar_t version #6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6491 +/- ##
==========================================
- Coverage 93.40% 92.98% -0.42%
==========================================
Files 845 845
Lines 264353 264650 +297
==========================================
- Hits 246911 246079 -832
- Misses 17442 18571 +1129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds wchar_t (wide character) versions of the net load API functions for Windows to support file paths with non-ASCII characters. It also includes minor test updates to copy additional layer support flags.
- Adds
load_param(const wchar_t*),load_param_bin(const wchar_t*), andload_model(const wchar_t*)methods for Windows in the Net class - Exposes these new methods through the C API with
_wsuffixes - Updates Python bindings to use
std::wstringon Windows - Updates test code to copy
support_any_packingandsupport_vulkan_any_packingflags
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/net.h | Declares wchar_t overloads for load_param, load_param_bin, and load_model methods on Windows |
| src/net.cpp | Implements wchar_t overloads using _wfopen for Windows file access |
| src/c_api.h | Declares C API functions with _w suffix for wchar_t support on Windows |
| src/c_api.cpp | Implements C API wrappers that call the C++ wchar_t methods |
| python/src/main.cpp | Updates Python bindings to accept std::wstring paths on Windows |
| tests/test_squeezenet.cpp | Copies support_any_packing and support_vulkan_any_packing flags in test layer wrapper |
| docs/how-to-use-and-FAQ/ncnn-load-model.md | Documents the new wchar_t API variants in the load model reference table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.