Skip to content

Conversation

@nihui
Copy link
Member

@nihui nihui commented Jan 6, 2026

No description provided.

Added functionality to remove comments and extra spaces from shader compilation data.
@github-actions github-actions bot added the cmake label Jan 6, 2026
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.29%. Comparing base (419db5e) to head (cbd314d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6493    +/-   ##
========================================
  Coverage   93.29%   93.29%            
========================================
  Files         845      845            
  Lines      265560   266326   +766     
========================================
+ Hits       247743   248476   +733     
- Misses      17817    17850    +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds shader preprocessing steps to the CMake build system that remove comments and collapse extra whitespace from GLSL shader files before they are compiled into binary headers. This optimization reduces the size of shader code embedded in the final binary.

Key Changes

  • Added regex-based comment removal to strip single-line C++ style comments (//)
  • Added space/tab consolidation to replace multiple consecutive spaces or tabs with a single space

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nihui nihui merged commit dce28a0 into Tencent:master Jan 7, 2026
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants