Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rate): rate popover #545

Closed
wants to merge 2 commits into from
Closed

refactor(rate): rate popover #545

wants to merge 2 commits into from

Conversation

fengchunqi
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

移动端 mobile-vue 发布正式版 #514

💡 需求背景和解决方案

📝 更新日志

  • refactor(rate): rate增加popover展示

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@anlyyao anlyyao mentioned this pull request Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

失败

@LeeJim
Copy link
Collaborator

LeeJim commented Apr 4, 2023

邮箱校验不通过

@fengchunqi fengchunqi changed the title refactor(rate): rate增加popover展示 refactor(rate): rate popover Apr 6, 2023
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 6, 2023

问题:

  1. 样式。旧的样式移除,仅保留v2样式。理论上dom结构和小程序端保持一致后,样式可以直接复用,不需要自己重写样式。
  2. demo示例未对齐。建议参考小程序端命名方式,然后直接复用小程序端组件的README.md中的“代码演示”部分到src/_common/docs/mobile/api_v2/rate.md中
  3. 更新示例后需要更新快照。分别执行 npm run test:demo,npm run test:snap-update

@@ -1 +1,3 @@
import '../../_common/style/mobile/components/rate/_index.less';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

旧的样式文件移除,仅保留v2

@fengchunqi fengchunqi closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants