refactor(rate): rate tips #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeJim
requested changes
Apr 13, 2023
src/rate/demos/base.vue
Outdated
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
| <CustomCell title="请点击评分"> | |||
| <t-rate v-model="value" clearable :gap="defaultGap" @change="changeValue" /> | |||
| <CustomCell title="实心评分"> | |||
There was a problem hiding this comment.
建议把这个 custom-cell 组件移除，不要依赖任何二次封装的。
用户复制示例代码的时候就没法直接用了：
There was a problem hiding this comment.
去掉CustomCell后，样式是单独都写在每个示例里面吗？
| <FilledDemo /> | ||
| <br /> | ||
| <tdesign-demo-block title="01 组件类型" summary="实心评分"> | ||
| <BaseDemo /> |
src/rate/rate.vue
Outdated
| import { ref, computed, defineComponent, ExtractPropTypes, PropType, ComputedRef } from 'vue'; | ||
| import { StarFilledIcon, StarIcon } from 'tdesign-icons-vue-next'; | ||
| import { ref, computed, defineComponent } from 'vue'; | ||
| import { IconFont } from 'tdesign-icons-vue-next'; |
There was a problem hiding this comment.
现在不是改成传icon name了吗
|
提交的分支也不对，需要合并进 develop |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
移动端 mobile-vue 发布正式版 #514
💡 需求背景和解决方案
📝 更新日志
refactor(rate): rate增加tips
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单