Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/toast #596

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Refactor/toast #596

merged 5 commits into from
Apr 19, 2023

Conversation

mistakers
Copy link
Contributor

@mistakers mistakers commented Apr 17, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

相关pr

common: https://github.com/Tencent/tdesign-common/pull/1287/files

💡 需求背景和解决方案

📝 更新日志

  • break(Toast): 调整DOM结构

  • break(Toast): destory 事件名称更正为 destroy

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 17, 2023

问题:

  1. 流水线挂了
  2. demo 未对齐视觉,正确视觉 https://codesign.qq.com/app/design/kv8398dMMM9nKeg/P4VlZMeqekRZq6w/inspect?team_id=1DWk9JNNL89GnMm
  3. demo文件命名建议也对齐小程序,然后复用小程序端的.md。如下所示

截屏2023-04-18 00 14 39

截屏2023-04-18 00 15 36

@mistakers
Copy link
Contributor Author

修复流水问题

@mistakers
Copy link
Contributor Author

md 文档改造完成

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 19, 2023

流水线失败原因:theme 属性可选项值变更后,原dev分支的示例中 theme 校验失败,从而导致流水线失败,与当前分支代码无关

@anlyyao anlyyao merged commit 9b3d2db into Tencent:refactor/toast Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants