Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Slider): new slider #610

Merged
merged 2 commits into from
Apr 23, 2023
Merged

refactor(Slider): new slider #610

merged 2 commits into from
Apr 23, 2023

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented Apr 20, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

相关pr

common: Tencent/tdesign-common#1290

💡 需求背景和解决方案

📝 更新日志

  • break(Slider): 调整 DOM 结构

  • break(Slider): label 默认值变更为 false

  • break(Slider): 移除 dragend、dragstart 事件

  • feat(Slider): 新增 theme 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@anlyyao anlyyao mentioned this pull request Apr 20, 2023
@anlyyao anlyyao force-pushed the refactor/slider branch 2 times, most recently from 0be7f8b to 2642843 Compare April 20, 2023 12:02
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

完成

@github-actions
Copy link
Contributor

Size Change: +2.21 kB (0%)

Total Size: 445 kB

Filename Size Change
./dist/tdesign.css 36.2 kB +187 B (+1%)
./dist/tdesign.js 258 kB +1.02 kB (0%)
./dist/tdesign.min.css 28.2 kB +258 B (+1%)
./dist/tdesign.min.js 123 kB +746 B (+1%)

@anlyyao anlyyao requested a review from LeeJim April 21, 2023 03:52
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还存在另外 2 个问题:

  • 无法点击切换
  • 缺少使用了 showExtremeValue 的示例

src/slider/slider.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Size Change: +4.75 kB (+1%)

Total Size: 448 kB

Filename Size Change
./dist/tdesign.css 36.2 kB +202 B (+1%)
./dist/tdesign.js 260 kB +2.64 kB (+1%)
./dist/tdesign.min.css 28.4 kB +509 B (+2%)
./dist/tdesign.min.js 123 kB +1.4 kB (+1%)

@LeeJim LeeJim merged commit bd8bba0 into develop Apr 23, 2023
@LeeJim LeeJim deleted the refactor/slider branch April 23, 2023 10:47
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants