Skip to content

fix(Popup): avoid repeatedly triggering updateScrollTop #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RylanBot wants to merge 4 commits into
base: develop
Choose a base branch
from
+16 −6
Open

fix(Popup): avoid repeatedly triggering updateScrollTop #4062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd37825
fix(Popup): avoid repeatedly triggering `updateScrollTop` when the st…
RylanBot Jan 6, 2026
6cad2d6
chore: stash changelog [ci skip]
tdesign-bot Jan 6, 2026
cd89c91
fix(Popup): arrow position not correct when content is dynamic
RylanBot Jan 7, 2026
9047c47
chore: update changelog
RylanBot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/components/guide/__tests__/__snapshots__/vitest-guide.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ exports[`Guide Component > GuideStep.body works fine 1`] = `
</div>
<div
class="t-popup__arrow"
style="left: 8px; margin-left: 0px;"
style=""
/>
</div>
</div>
Expand Down Expand Up @@ -627,7 +627,7 @@ exports[`Guide Component > GuideStep.highlightContent works fine 1`] = `
</div>
<div
class="t-popup__arrow"
style="left: 8px; margin-left: 0px;"
style=""
/>
</div>
</div>
Expand Down Expand Up @@ -997,7 +997,7 @@ exports[`Guide Component > GuideStep.placement is equal to bottom-left 1`] = `
</div>
<div
class="t-popup__arrow"
style="left: 8px; margin-left: 0px;"
style=""
/>
</div>
</div>
Expand Down Expand Up @@ -1171,7 +1171,7 @@ exports[`Guide Component > GuideStep.stepOverlayClass is equal to t-test-guide-s
</div>
<div
class="t-popup__arrow"
style="left: 8px; margin-left: 0px;"
style=""
/>
</div>
</div>
Expand Down Expand Up @@ -1349,7 +1349,7 @@ exports[`Guide Component > GuideStep.title works fine 1`] = `
</div>
<div
class="t-popup__arrow"
style="left: 8px; margin-left: 0px;"
style=""
/>
</div>
</div>
Expand Down
5 changes: 4 additions & 1 deletion packages/components/popup/Popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import { getTransitionParams } from './utils/transition';

import type { PopupInstanceFunctions, TdPopupProps } from './type';

/**
* @internal
*/
export interface PopupProps extends TdPopupProps {
// 是否触发展开收起动画，内部下拉式组件使用
expandAnimation?: boolean;
Expand Down Expand Up @@ -217,7 +220,7 @@ const Popup = forwardRef<PopupInstanceFunctions, PopupProps>((originalProps, ref
});
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [visible, popupElement, updateScrollTop]);
}, [visible, content]);

function handleExited() {
setIsOverlayHover(false);
Expand Down
7 changes: 7 additions & 0 deletions packages/tdesign-react/.changelog/pr-4062.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
pr_number: 4062
contributor: RylanBot
---

- fix(Cascader): 修复在弹出层可见期间，滚动位置被意外更新的问题 @RylanBot ([#4062](https://github.com/Tencent/tdesign-react/pull/4062))
- fix(Popup): 修复 `content` 动态修改时，箭头位置不稳定的问题 @RylanBot ([#4062](https://github.com/Tencent/tdesign-react/pull/4062))
Loading