fix(reactify): fix slot render and attributes filter #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonardoSya
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
honkinglin and
uyarn
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
reactify增加两处修复：
1. 修复部分prop不挂载slot的问题
问题描述：
icon,header,footer等prop，既不是webc组件在slotProps中显式声明的props，也不以"Slot"结尾。因此插槽内容为空修复：对任意ReactElement prop，还会kebab-case后去shadow dom查找同名slot，有的话就挂载进去
2. render 只透传String/Numebr/Boolean，避免复杂对象被当作 attribute 导致传成 [object Object] 的问题
现在，复杂对象会被下放到
update()中处理📝 更新日志
@tdesign-react/chat
fix(reactify): 修复部分prop不挂载slot的问题
fix(reactify): 修复复杂对象被当作 attribute 传递的问题
☑️ 请求合并前的自查清单