Skip to content

fix(Dialog): allow overlay click callback when close disabled #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uyarn merged 2 commits into from
Jan 9, 2026
+18 −8
Merged

fix(Dialog): allow overlay click callback when close disabled #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69b4173
fix(dialog): allow overlay click callback when close disabled
TidySongS Jan 7, 2026
278e1e5
chore: stash changelog [ci skip]
tdesign-bot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/components/dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,18 @@ const Dialog = forwardRef<DialogInstance, DialogProps>((originalProps, ref) => {
}

const onMaskClick = (e: React.MouseEvent<HTMLDivElement>) => {
if (showOverlay && (closeOnOverlayClick ?? local.closeOnOverlayClick)) {
// 判断点击事件初次点击是否为内容区域
if (contentClickRef.current) {
contentClickRef.current = false;
} else if (e.target === dialogPosition.current) {
onOverlayClick?.({ e });
onClose?.({ e, trigger: 'overlay' });
}
if (!showOverlay) return;
// 判断点击事件初次点击是否为内容区域
if (contentClickRef.current) {
contentClickRef.current = false;
return;
}
if (e.target !== dialogPosition.current) return;
// 触发蒙层点击事件
onOverlayClick?.({ e });
// 触发关闭事件
if (closeOnOverlayClick ?? local.closeOnOverlayClick) {
onClose?.({ e, trigger: 'overlay' });
}
};

Expand Down
6 changes: 6 additions & 0 deletions packages/tdesign-react/.changelog/pr-4065.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
pr_number: 4065
contributor: TidySongS
---

- fix(Dialog): 修复 `closeOnOverlayClick` 为 `false` 时，`onOverlayClick` 无法触发的问题 @TidySongS ([#4065](https://github.com/Tencent/tdesign-react/pull/4065))