Merge branch 'feat/optimize-log-message' into 'main' (merge request !69)

feat: optimize log message
Tencent · Dec 23, 2024 · 92d7770 · 92d7770
2 parents 67bedb9 + d5ed38b
commit 92d7770
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## v1.5.3
+* fix: optimize warning message for modifing vector indexes interface
+
 ## v1.5.2
 * fix: optimize the interface modifing vector indexes 
 

diff --git a/tcvdbtext/encoder/bm25_encoder.go b/tcvdbtext/encoder/bm25_encoder.go
@@ -125,7 +125,7 @@ func (bm25 *BM25Encoder) SetDefaultParams(bm25Language string) error {
 		}
 		defer file.Close()
 
-		log.Printf("[Waring] start to download dictionary %v and store it in %v, please wait a moment",
+		log.Printf("[Warning] start to download dictionary %v and store it in %v, please wait a moment",
 			bm25ParamsUrl, fileStoragePath)
 		resp, err := http.Get(bm25ParamsUrl)
 		if err != nil {

diff --git a/tcvdbtext/tokenizer/jieba_tokenizer.go b/tcvdbtext/tokenizer/jieba_tokenizer.go
@@ -48,7 +48,7 @@ func NewJiebaTokenizer(params *TokenizerParams) (Tokenizer, error) {
 	defaultStopWordFilePath := dir + STOP_WORD_PATH
 
 	if params == nil {
-		log.Printf("[Waring] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
+		log.Printf("[Warning] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
 		jbt.StopWordsFilePath = defaultStopWordFilePath
 		err := jbt.Jieba.LoadStop(defaultStopWordFilePath)
 		if err != nil {
@@ -76,7 +76,7 @@ func NewJiebaTokenizer(params *TokenizerParams) (Tokenizer, error) {
 	if ok {
 		jbt.StopWordsEnable = stopWordsEnable
 		if stopWordsEnable {
-			log.Printf("[Waring] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
+			log.Printf("[Warning] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
 			jbt.StopWordsFilePath = defaultStopWordFilePath
 			err := jbt.Jieba.LoadStop(defaultStopWordFilePath)
 			if err != nil {
@@ -206,7 +206,7 @@ func (jbt *JiebaTokenizer) UpdateParameters(params TokenizerParams) error {
 		dir := filepath.Dir(filePath)
 		defaultStopWordFilePath := dir + STOP_WORD_PATH
 
-		log.Printf("[Waring] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
+		log.Printf("[Warning] Jieba will use default file for stopwords, which is %v", defaultStopWordFilePath)
 		jbt.StopWordsFilePath = defaultStopWordFilePath
 		err := jbt.Jieba.LoadStop(defaultStopWordFilePath)
 		if err != nil {

diff --git a/tcvectordb/ai_document_sets.go b/tcvectordb/ai_document_sets.go
@@ -696,7 +696,7 @@ func (i *implementerAIDocumentSets) loadAndSplitTextCheckParams(param *LoadAndSp
 		isMarkdown = true
 	}
 	if !isMarkdown && param.SplitterPreprocess.ChunkSplitter != nil && *param.SplitterPreprocess.ChunkSplitter != "" {
-		log.Printf("[Waring] %s", "param SplitterPreprocess.ChunkSplitter will be ommitted, "+
+		log.Printf("[Warning] %s", "param SplitterPreprocess.ChunkSplitter will be ommitted, "+
 			"because only markdown filetype supports defining ChunkSplitter")
 	}
 

diff --git a/tcvectordb/base_collection.go b/tcvectordb/base_collection.go
@@ -575,7 +575,7 @@ func optionParamsFromIndexParams(column *api.IndexColumn, v IndexParams) {
 			column.Params.Nlist = param.NList
 		}
 	default:
-		log.Printf("[Waring] Unknown type: %v", reflect.TypeOf(v))
+		log.Printf("[Warning] unknown type: %v", reflect.TypeOf(v))
 	}
 
 }

diff --git a/tcvectordb/base_index_flat.go b/tcvectordb/base_index_flat.go
@@ -2,6 +2,7 @@ package tcvectordb
 
 import (
 	"context"
+	"log"
 
 	"github.com/tencent/vectordatabase-sdk-go/tcvectordb/api"
 	"github.com/tencent/vectordatabase-sdk-go/tcvectordb/api/index"
@@ -147,10 +148,11 @@ func (i *implementerFlatIndex) ModifyVectorIndex(ctx context.Context, databaseNa
 	}
 	req.RebuildRules = param.RebuildRules
 
-	res := new(index.ModifyVectorIndexReq)
+	res := new(index.ModifyVectorIndexRes)
 	err := i.Request(ctx, req, res)
 	if err != nil {
 		return err
 	}
+	log.Println("[Warning]", res.Msg)
 	return nil
 }
diff --git a/tcvectordb/rpc_base_collection.go b/tcvectordb/rpc_base_collection.go
@@ -481,7 +481,7 @@ func optionRpcParamsFromIndexParams(column *olama.IndexColumn, v IndexParams) {
 			column.Params.Nlist = param.NList
 		}
 	default:
-		log.Printf("[Waring] Unknown type: %v", reflect.TypeOf(v))
+		log.Printf("[Warning] unknown type: %v", reflect.TypeOf(v))
 	}
 }
 

diff --git a/tcvectordb/rpc_base_index_flat.go b/tcvectordb/rpc_base_index_flat.go
@@ -2,6 +2,7 @@ package tcvectordb
 
 import (
 	"context"
+	"log"
 
 	"github.com/tencent/vectordatabase-sdk-go/tcvectordb/olama"
 )
@@ -111,9 +112,12 @@ func (r *rpcImplementerFlatIndex) ModifyVectorIndex(ctx context.Context, databas
 		req.RebuildRules.Throttle = defaultThrottle
 	}
 
-	_, err := r.rpcClient.ModifyVectorIndex(ctx, req)
+	res, err := r.rpcClient.ModifyVectorIndex(ctx, req)
 	if err != nil {
 		return err
 	}
+	if res != nil {
+		log.Println("[Warning]", res.Msg)
+	}
 	return nil
 }
diff --git a/tcvectordb/version.go b/tcvectordb/version.go
@@ -18,4 +18,4 @@
 
 package tcvectordb
 
-const SDKVersion = "v1.5.2"
+const SDKVersion = "v1.5.3"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,4 +18,4 @@

		package tcvectordb

		const SDKVersion = "v1.5.2"
		const SDKVersion = "v1.5.3"