Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subject template add member #279

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Fix subject template add member #279

merged 6 commits into from
Dec 13, 2023

Conversation

zhu327
Copy link
Member

@zhu327 zhu327 commented Dec 8, 2023 •
edited
Loading

变更点(Changes)

  • 人员模版会引入同一个subject, 同时更新多个group的场景, 所以需要做合并处理
  • 在group auth type变更时也需要处理人员模版的数据

相关issues (Which issues this PR fixes)

  • Fixes #

备注(Special notes)

@zhu327 zhu327 marked this pull request as ready for review December 8, 2023 07:27
@zhu327 zhu327 requested a review from wklken December 8, 2023 07:27
wklken
wklken reviewed Dec 12, 2023
View reviewed changes
pkg/service/group.go Outdated Show resolved Hide resolved
pkg/service/group.go Outdated Show resolved Hide resolved
@zhu327 zhu327 merged commit 5b561bf into TencentBlueKing:develop Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wklken wklken wklken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhu327 @wklken