Skip to content

fix: Profiling 火焰图滚动时关闭 tooltip --bug=160034346 #11282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liangling0628 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Profiling 火焰图滚动时关闭 tooltip --bug=160034346 #11282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...bpack/src/monitor-ui/chart-plugins/plugins/profiling-graph/flame-graph/flame-graph-v2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
import { computed, defineComponent, nextTick, onBeforeUnmount, ref, watch } from 'vue';
import { computed, defineComponent, nextTick, onBeforeUnmount, onMounted, ref, watch } from 'vue';
import { shallowRef } from 'vue';

import { addListener, removeListener } from '@blueking/fork-resize-detector';
Expand Down Expand Up @@ -302,8 +302,21 @@ export default defineComponent({
function handleResizeGraph() {
chartInstance?.resize();
}
// 图表区域滚动时关闭 tooltip 与右键菜单：tooltip appendToBody 为 false 渲染在图表容器内，
// 滚动后会与内容错位甚至滚出可视区，故滚动即关闭（capture 阶段监听，可捕获祖先滚动容器的滚动）
function handleScroll() {
chartInstance?.dispatchAction({ type: 'hideTip' });
if (showContextMenu.value) {
showContextMenu.value = false;
contextMenuRect.value.left = -1;
}
}
onMounted(() => {
window.addEventListener('scroll', handleScroll, true);
});
onBeforeUnmount(() => {
removeListener(wrapperRef.value, handleResizeGraph);
window.removeEventListener('scroll', handleScroll, true);
});
return {
chartRef,
Expand Down
Loading