feat: 完善清洗模板字段处理 - #12027
Merged
yiqiwang-17 merged 7 commits intoAug 19, 2026
Merged
Conversation
yiqiwang-17
reviewed
Aug 19, 2026
yiqiwang-17
left a comment
Collaborator
There was a problem hiding this comment.
整体方向认可:etl_storage/base.py:1064 确实是 field["is_dimension"] 硬取,历史模板缺该键会 500;模板 serializer 从自由 DictField 收紧也能挡住脏数据。
但有 3 条 P1 建议修完再合,已按位置发在对应行:
- 兜底只补了
is_dimension,同一批历史模板缺is_delete等键时仍会 500(transfer.py)。 etl_params换成 Serializer 后会把 DRF 默认值写进模板,其中record_parse_failure会被强制置True,与采集项侧联动语义相反(serializers.py:1177)。etl_fields校验收紧属不兼容变更,且本次收紧零测试覆盖(serializers.py:1178)。
另外 PR 描述为空,建议把上述行为变化(尤其是模板 etl_params 持久化内容的变化)补进描述,方便后续回溯。
yiqiwang-17
merged commit Aug 19, 2026
1c12685
into
TencentBlueKing:feat/clean_template
5 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/clean_template #12027 +/- ##
======================================================
Coverage ? 61.83%
======================================================
Files ? 927
Lines ? 68172
Branches ? 0
======================================================
Hits ? 42156
Misses ? 26016
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.