feat(metric): add database redis metric collector for prometheus #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrLYC
reviewed
Aug 19, 2022
| type DatabaseCollector struct { | ||
| name string | ||
|
|
||
| connections map[string]*sql.DB |
There was a problem hiding this comment.
sql db里面本身是没有定义interface的, 这里的 *sql.DB 是sql规范入口生成的, 必须是这个, 如果自行定义一个pinger的接口意义不大, 反而可能会被错误的使用, 所以这里明确需要给到是 *sql.DB
| type RedisCollector struct { | ||
| name string | ||
|
|
||
| clients map[string]*redis.Client |
There was a problem hiding this comment.
同上, redis本身也没有定义接口, 这里不管sentinel的配置, 实例化由调用方处理, sentinel 返回也是一个 *redis.Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.